Remove restriction from publish snapshot script that jars must end in -SNAPSHOT.jar. #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… -SNAPSHOT.jar. Signed-off-by: Marc Handalian <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1188 +/- ##
============================================
+ Coverage 93.49% 93.77% +0.28%
Complexity 10 10
============================================
Files 100 105 +5
Lines 2551 2618 +67
Branches 7 9 +2
============================================
+ Hits 2385 2455 +70
+ Misses 158 153 -5
- Partials 8 10 +2
Continue to review full report at Codecov.
|
dblock
approved these changes
Nov 30, 2021
peternied
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marc Handalian [email protected]
Description
Remove restriction from publish snapshot script that jars must end in -SNAPSHOT.jar.
The reason this was introduced in the first place was because of #447, the build-tools publication includes an additional test-fixtures jar that would sometimes get picked up and deployed instead of the actual build-tools jar. To account for this, this will look for a jar named test-fixtures and exclude it.
This is only necessary because we are deploying pre-built artifacts directly with the deploy-file plugin, it is not a problem if both of those files were to get deployed with a normal gradle publish - see #1182.
Issues Resolved
closes #1180
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.